Conversation
Narrows posthog_frozen_perf to the Trino targets and the queries bounded by per-split Parquet footer handling, to measure PostHog/trino#72 without the full five-engine run: - targets: trino, trino_cached (no PGWire, no Athena) - queries: q_events_total_v5, q_events_count_one_day_v5, and q_events_by_name_march_2026_v5 as a scan-bound regression check - 1 warmup + 2 measured iterations; no properties comparison The scenario keeps its name because scenario-dev.yml and run.sh select the Trino suite and image by it. The scenario tests that pin the nightly shape are adjusted to the targeted one. Branch runs do not publish to the perf dashboard (publishing requires refs/heads/main). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: likely reduced Warnings
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge. This branch exists only to run a focused Trino perf test. It trims the nightly
posthog_frozen_perfscenario in place and adjusts the tests that pin the nightly setup. Merging it would shrink the nightly benchmark and drop PGWire, Athena and the properties comparison.Purpose
This runs the frozen PostHog perf scenario against Trino only, to measure Hoglake connector changes without the full five-engine suite. The full suite takes about 2 h 20 min; this takes about 25 min.
It was used to verify PostHog/trino#72, which removed the per-split floor from Hoglake byte-range reads.
What it changes
trinoandtrino_cachedonly, in both the scenario and the query catalog. PGWire and Athena are dropped.q_events_total_v5andq_events_count_one_day_v5, plusq_events_by_name_march_2026_v5as a check that scans didn't get slower.athena_externalrelation variant is removed, because paired catalogs must declare exactly the variants their targets need.tests/mw-dev/scenario/runner_test.go, the target assertion now expects the two Trino targets, and the properties-step test is skipped. The workflow runs these tests before deploying. The catalog-contents tests intests/perf/corepin the nightly corpus and will fail on this branch; the workflow doesn't run them.The scenario keeps its name because
scenario-dev.ymlandtests/mw-dev/run.shselect the Trino suite, image and cells byposthog_frozen_perf.Branch runs don't publish to the perf dashboard; publishing requires
refs/heads/main.How to run
Use a digest-pinned image from
scripts/resolve_trino_master_image.sh, or omittrino_imageto use the newest PostHog/trino master build:Results are in the run's
scenario-dev-posthog_frozen_perf-<run>-1artifact, underperf/query_results.csv.Result for PostHog/trino#72
Run 36000704000 used the image built from the #72 merge commit. The baseline is scheduled run 35976233587 on 2026-09-24, from master before #72. Median seconds:
trinobefore → aftertrino_cachedbefore → afterCOUNT(*)All 12 query runs succeeded with the same row counts as the baseline. The artifacts record timings and row counts, not result values.
🤖 Generated with Claude Code