Allow to disable certificate verification on connection to ClickHouse #7
+136
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daesgar
approved these changes
Jan 17, 2025
| IdleConnTimeout: 90 * time.Second, | ||
| TLSHandshakeTimeout: 10 * time.Second, | ||
| ExpectContinueTimeout: 1 * time.Second, | ||
| } | ||
|
|
||
| if cfgCp.InsecureSkipVerify { |
There was a problem hiding this comment.
Maybe we can just?
Suggested change
| if cfgCp.InsecureSkipVerify { | |
| transport.TLSClientConfig = &tls.Config{ | |
| InsecureSkipVerify: cfgCp.InsecureSkipVerify, //nolint:gosec | |
| } |
Not sure if creating the TLSClientConfig object changes the behavior though, in that case, just ignore this!
There was a problem hiding this comment.
I had this code as you suggested before.
I've tried to dig on this one into the source. There's a one warning about HTTP2. I have no confidence in committing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to skip ssl certificate validation when connecting to ClickHouse.
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments