fix: recording data loss on crashes and restarts #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to support new backend API structure: - Renamed segments to localSegmentBuffer in activeRecordingStore - Updated to use appendTranscriptSegments instead of updateDesktopRecordingTranscript - Backend now uses append_segments endpoint for incremental updates - Updated RecordingView to use transcript_segments for past recordings - Simplified NotetakerView to store only recording ID instead of full item These changes support the new append-only API pattern which prevents data loss and makes transcript updates more reliable.
lucasheriques
changed the title
Fixes critical data loss bugs where recordings would be deleted from IndexedDB on app restart or when Recall SDK crashed during a meeting. Changes: - Reset isRecording flag when SDK crashes to allow recovery - Mark interrupted recordings as 'error' instead of deleting from IDB - Keep 'ready' recordings in IDB for fast access (user can delete manually) - Add lastSegmentTime tracking to detect silent failures - Add Recover/Discard UI buttons for interrupted recordings - Simplify meeting-detected log output The architecture now treats IDB as source of truth with non-destructive operations, giving users full control over interrupted recordings.
lucasheriques
force-pushed
the
chore/update-recording-api
branch
from
a7fc98d to
f1fef0c
Compare
lucasheriques
commented
Oct 29, 2025
| async duplicateTask(taskId: string) { | ||
| const task = await this.getTask(taskId); | ||
| return this.createTask( | ||
| // @ts-expect-error (marking it as ignore since unrelated to this PR) |
There was a problem hiding this comment.
added these because after syncing the latest openai api changed it start failing. let me know if i should remove though
lucasheriques
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes data loss when app restarts during a recording or when the Recall SDK crashes.
Changes
isRecordingflag when SDK crashes so it can resume after auto-restartlastSegmentTimeto detect when segments stop comingNow treats IDB as source of truth - recordings survive crashes and users decide what to keep.