Skip to content

Fix the test matrix #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 8, 2025
Merged

Fix the test matrix #133

merged 18 commits into from
Feb 8, 2025

Conversation

Jaykul
Copy link
Member

@Jaykul Jaykul commented Feb 7, 2025

Remove outdated github actions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Jaykul
Copy link
Member Author

Jaykul commented Feb 7, 2025

It turns out that zyborg/pester-tests-report can't do Pester 4 so ... I upgraded all the tests to Pester 5

@Jaykul
Copy link
Member Author

Jaykul commented Feb 7, 2025

Worse. It turns out the zyborg/pester-tests-report can't handle how big our test report would be. Ugh.

However, on top of that the Parameters.Tests.ps1 are still failing -- and they only fail in the test matrix, not in the initial build, nor in earthly (nor on my computer, obviously). I don't know what's happening there yet.

@Jaykul Jaykul force-pushed the joel/Rebuild branch 6 times, most recently from eba63de to c64711d Compare February 8, 2025 18:21
@Jaykul
Copy link
Member Author

Jaykul commented Feb 8, 2025

OK. It took me a lot longer to figure that out than I would have liked, and too many attempts to fix it, but it turns out the problem with the test matrix was basically the fact that we use ModuleBuilder to build ModuleBuilder.

In the main build we use Invoke-Build and are very careful to import the right module for testing, but in the test matrix the tests were running against the installed copy instead of the newly built version.

@Jaykul Jaykul merged commit bff8e7a into main Feb 8, 2025
9 checks passed
@Jaykul Jaykul deleted the joel/Rebuild branch February 20, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant