improve error logging for fireworks

[narengogi]

No description provided.

[matter-code-review]

Description

Summary By MatterAI

🔄 What Changed

The pull request modifies src/providers/fireworks-ai/chatComplete.ts to enhance error handling. It introduces a conditional check for response.error to specifically use generateErrorResponse when an explicit error object is present. If no such error is found, it defaults to generateInvalidProviderResponseError for other malformed or unexpected responses from the Fireworks AI provider.

🔍 Impact of the Change

This change significantly improves the clarity and specificity of error messages originating from the Fireworks AI integration. By distinguishing between explicit API errors and general invalid responses, it makes debugging and issue resolution more efficient, thereby enhancing the overall reliability and maintainability of the system's interaction with the Fireworks AI service.

📁 Total Files Changed

• src/providers/fireworks-ai/chatComplete.ts: Improved error handling logic for Fireworks AI responses.

🧪 Test Added

N/A

🔒Security Vulnerabilities

N/A

Motivation

To provide more specific and actionable error messages from the Fireworks AI provider, improving debugging and system reliability.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)

How Has This Been Tested?

• Unit Tests
• Integration Tests
• Manual Testing

Screenshots (if applicable)

N/A

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Related Issues

N/A

Tanka Poem ♫

Response flows, now clear,
Errors caught with careful hand,
Debugging's swift.
Code's logic, a fine design,
System hums, a steady beat. 🚀

Sequence Diagram

sequenceDiagram
    participant Caller as "API Caller"
    participant ChatComplete as "FireworksAIChatComplete"
    participant ErrorResponse as "generateErrorResponse"
    participant InvalidResponse as "generateInvalidProviderResponseError"

    Caller->>ChatComplete: processResponse(response)
    Note over ChatComplete: Handles Fireworks AI API response

    alt response.error exists
        ChatComplete->>ErrorResponse: generateErrorResponse(response.error, FIREWORKS_AI)
        ErrorResponse-->>ChatComplete: errorObject
    else no response.error
        ChatComplete->>InvalidResponse: generateInvalidProviderResponseError(response, FIREWORKS_AI)
        InvalidResponse-->>ChatComplete: invalidResponseObject
    end

    ChatComplete-->>Caller: processedResponse/Error

Loading

[matter-code-review]

Good improvement to error handling by adding explicit error response generation for Fireworks AI provider errors.

[matter-code-review]

🛠️ Code Refactor

Issue: Missing explicit error handling for response.error cases
Fix: Added proper error response generation with provider-specific context
Impact: Improves error visibility and debugging for Fireworks AI failures

The addition of explicit error checking and response generation follows the established pattern used across other providers (zhipu, workers-ai, etc.) as shown in the AST grep results. This ensures consistent error handling behavior.