Add option to load ATOR config automatically on startup#6
Open
kovacs-levent wants to merge 1 commit intoPortSwigger:masterfrom
Open
Add option to load ATOR config automatically on startup#6kovacs-levent wants to merge 1 commit intoPortSwigger:masterfrom
kovacs-levent wants to merge 1 commit intoPortSwigger:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option to configure a filepath using
ATOR_CONFIG_FILEPATHenvironment variable.I am using ATOR to run authenticated Burp scans, and loading in the configuration file manually does not work well with automation efforts. I decided to modify the module instead to allow this type of config load on startup.
If it's useful for ATOR, I hope this can be merged, so I don't need to maintain a separate fork of the project for my use-case 👍
I also opened this PR to the main repo, because I didn't see much activity on pending PRs. Hopefully we can discuss the viability and usefulness of this feature on one of these PRs and get it merged synopsys-sig#47.