Create .gitignore and Java CI with Gradle #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AffluentAvo
approved these changes
Dec 28, 2020
AffluentAvo
approved these changes
May 6, 2021
|
@AffluentAvo why did you approve twice? |
|
Great pr. one thing I would request is that you use the upload artifact action so people can download the artifact instead of building it themselves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore: This ensures you don't push built binaries and stuff. You can put those in GitHub Releases
CI: Use GitHub Actions. You can test using multiple versions of Java (which you should) but for now I stuck with the default 1.8 and if you want to add several versions with a matrix strategy I can help you with that.