Generalize SingleYearDataset and MultipleYearDataset classes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juaristi22
changed the title
nikhilwoodruff
requested changes
Jul 23, 2025
Collaborator
|
Hi @juaristi22 , I just pulled the code and tried things out. I don't have a lot to add on this one. I would like to try out the |
nikhilwoodruff
requested changes
Jul 23, 2025
|
|
||
| # Create SingleYearDataset for each year | ||
| for year, entities in years_entities.items(): | ||
| self.datasets[year] = SingleYearDataset( |
Collaborator
There was a problem hiding this comment.
Add tests for loading and saving datasets pls
Collaborator
Author
There was a problem hiding this comment.
you mean to hugging face? or the load and save methods? (the load and save methods are used in the test_dataset_classes.py tests)
nikhilwoodruff
approved these changes
Jul 28, 2025
Collaborator
nikhilwoodruff
left a comment
nikhilwoodruff
left a comment
There was a problem hiding this comment.
Love it- really clean!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4
Fix #9
Fix #7
This pr also addresses the changelog issue in the merging workflow