Implement L0 regularization as it is done in us-data #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
baogorek
approved these changes
Jul 25, 2025
Collaborator
baogorek
left a comment
baogorek
left a comment
There was a problem hiding this comment.
Approving with comments. I don't want to block this PR so merge when ready. In the comments I mentioned I'd miss the print_reweighting_diagnostics function. Some of my L0 design decisions are staring me in the face, like combining both the original and the L0 implementation into one function. I was thinking we'd refactor into something different, but it's working and there is quite a bit of shared logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45
Fix #71