-
Notifications
You must be signed in to change notification settings - Fork 1
Enabling analytical diagnosis of targets and improve calibration dashboard #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…into maria/calibration-analytics
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 8 8
Lines 202 296 +94
=====================================
- Misses 202 296 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Approved on the non-analytical analysis parts but will leave @baogorek to review those. |
baogorek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could chat about design over a cup of coffee (for instance, should this be a separate utility or a method of Calibrate?), but really I'm interested in seeing 2 changes:
- Please return a data frame from the analytical method function
- In your test, use that data frame make sure that the loss is always zero. (Extra credit: use a harder target and ensure that it is not zero).
baogorek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after trying out the most recent changes in my test environment.
Fix #63
Fix #69
Fix #70