Skip to content

Conversation

@juaristi22
Copy link
Collaborator

@juaristi22 juaristi22 commented Jul 11, 2025

Fix #63
Fix #69
Fix #70

@vercel
Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
microcalibrate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 3:57pm

@juaristi22 juaristi22 requested a review from baogorek July 11, 2025 12:33
@juaristi22 juaristi22 changed the title Enabling analytical diagnosis of targets Enabling analytical diagnosis of targets and improve calibration dashboard Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (5b39b2f) to head (20a56c8).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/microcalibrate/calibration.py 0.00% 32 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #68   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          8       8           
  Lines        202     296   +94     
=====================================
- Misses       202     296   +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nikhilwoodruff
Copy link
Collaborator

Approved on the non-analytical analysis parts but will leave @baogorek to review those.

Copy link
Collaborator

@baogorek baogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could chat about design over a cup of coffee (for instance, should this be a separate utility or a method of Calibrate?), but really I'm interested in seeing 2 changes:

  1. Please return a data frame from the analytical method function
  2. In your test, use that data frame make sure that the loss is always zero. (Extra credit: use a harder target and ensure that it is not zero).

Copy link
Collaborator

@baogorek baogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after trying out the most recent changes in my test environment.

@juaristi22 juaristi22 merged commit 1d25dcf into main Jul 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants