Skip to content

Fix negative values in rel_abs_error #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juaristi22 merged 1 commit into from
Jun 30, 2025
Merged

Fix negative values in rel_abs_error #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
changed:
- Taking abs val for abs_rel_error denominator.
4 changes: 3 additions & 1 deletion src/microcalibrate/utils/log_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ def log_performance_over_epochs(
"error": err,
"abs_error": abs(err),
"rel_abs_error": (
abs(err) / target_val if target_val != 0 else np.nan
abs(err) / abs(target_val)
if target_val != 0
else np.nan
),
}
)
Expand Down