Create Collector Manager Prototype #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-chamberlain
requested changes
Dec 22, 2024
Contributor
josh-chamberlain
left a comment
josh-chamberlain
left a comment
There was a problem hiding this comment.
@maxachis wonderful! shit just got real, and quickly. My only requests are about documentation:
- we need at least a blurb in the README about this; that table of modules doesn't include
collector manager. - I don't think it'd be a bad idea to pop everything in 118 into a README in the collector_manager directory, or in a slightly condensed form in the main README. All that stuff is great information, but issues are highly ephemeral.
josh-chamberlain
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118