Refactor Muckrock Scraper #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create explicit "main" method * Extract logic to functions * Add detailed docstrings * Add some comments
* Create explicit "main" method * Extract logic to functions * Add detailed docstrings * Add some comments and TODOs
* Add detailed docstrings * Add some comments and TODOs
* Create explicit main function and `__main__` section * Add detailed docstrings * Add some comments and TODOs
* Extract logic from `muck_get.py` and `download_muckrock_foia.py` * Create constants for base muckrock api url and foia extension of base url
* Extract logic for loading from and saving to json files to separate functions * Add TODOs
* Extract `muck_get.py` logic to FOIA searcher * Remove deprecated `download_muckrock_foia.py`
* Create MuckrockFetcher base class * Implement in FOIAFetcher * Create JurisdictionFetcher and AgencyFetcher * Replace relevant logic in `generate_detailed_muckrock_csv.py`
* Create Enum Class * Simplify Agency Info data creation * Extract logic to separate functions
* Create Enum Class * Simplify Agency Info data creation * Extract logic to separate functions
* Create LoopFetcher classes * Implement in `get_allegheny_foias`
* Create SQLClient classes * Add custom exception handling to Muckrock Fetcher. * Clean up comments * Extract some logic to separate functions.
* Create FOIA DB Searcher class, incorporate into module * Extract logic to functions
* Move all class files into `/classes` module
Collaborator
Author
|
Closing this as I'm working it into #122 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #105
Refactors Muckrock Scraper, getting rid of redundant code, modularizing, and otherwise doing quality of life improvements.