Skip to content

Add extra button press for German SID Helper #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 2 commits into from
May 5, 2026
Merged

Add extra button press for German SID Helper #1229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5dd8cf
add extra button press for German in SID sequence
theastrogoth May 4, 2026
87ddf2f
safely subtract
theastrogoth May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions SerialPrograms/Source/PokemonFRLG/Programs/RngManipulation/PokemonFRLG_SidHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ namespace{
void set_sid_from_name_screen(
SingleSwitchProgramEnvironment& env,
ProControllerContext& context,
const uint64_t& SID_DELAY
const uint64_t& SID_DELAY,
bool extra_press_at_end
){
// this is performed blind to try to maximize consistency of timing
// ensure the OK button is selected
Expand All @@ -122,6 +123,12 @@ void set_sid_from_name_screen(
? SID_DELAY - 13700
: 0
);

if (extra_press_at_end){
pbf_press_button(context, BUTTON_A, 200ms, 800ms);
delay = delay > 1000ms ? delay - 1000ms : 0ms;
}

pbf_press_button(context, BUTTON_A, 200ms, delay);

// finish dialogue and lock in SID
Expand Down Expand Up @@ -292,10 +299,12 @@ void SidHelper::program(SingleSwitchProgramEnvironment& env, ProControllerContex

const double& FIXED_ADVANCES_OFFSET = 7; // determined empirically. Probably not console/setup dependent

bool extra_press_at_end = (LANGUAGE == Language::German);

const uint64_t SID_DELAY = uint64_t((TARGET_ADVANCES - 2*FINAL_TEXT_FRAMES + FIXED_ADVANCES_OFFSET) * FRAME_DURATION / 2); // advances pass 2 by 2
env.log("Delay: " + std::to_string(SID_DELAY) + "ms");

set_sid_from_name_screen(env, context, SID_DELAY);
set_sid_from_name_screen(env, context, SID_DELAY, extra_press_at_end);
finish_intro_animations(env, context);
navigate_to_trainer_card(env, context);

Expand Down