[Major Rework] Lofty Pillars #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #229 |
alexytomi
force-pushed
the
Project/Lofty_Pillars
branch
2 times, most recently
from
635d480 to
4fe32d3
Compare
RealEthanPlayzDev
approved these changes
Jan 5, 2025
Signed-off-by: sa1672ndo <[email protected]>
cleaned up some stuff and added couple of mods Signed-off-by: sa1672ndo <[email protected]>
iOS 18 is horrible Signed-off-by: ItAnthon <[email protected]>
Signed-off-by: Dev1ss0 <[email protected]>
Signed-off-by: Dev1ss0 <[email protected]>
Signed-off-by: Dev1ss0 <[email protected]>
Signed-off-by: Dev1ss0 <[email protected]>
Signed-off-by: Dev1ss0 <[email protected]>
Signed-off-by: Dev1ss0 <[email protected]>
This reworks the folder structure as well as the sidebar to work alongside the navbar. This makes mobile navigation easier. The config file changes should allow everyone the old niceities of not specifying the path for every bloody file while having an actual folder structure that makes sense. This is already a feature in vuepress v2 but oh well, here's my reimplementation of that at least. The new thing to edit for contributors will be arrays.js.
Edits variable names, fixes a 404 link, and reorders arrays.js to have Android and iOS as their own objects rather than existing within FAQ in a gigantic object property.
…utter comments Incomplete because I'd be documenting stale things, which is pretty stupid
This file is supposed to be a config for an editor, hence it overrides the configs of everyone else. In theory this is good, in practice no one cares. This also looks horribly ugly since it uses tabs rather than spaces. Removing it seems sane.
… added some jsdoc comments Created a new function that handles non-grouped sidebar configuration in arrays.js rather than crudely hardcode the variable names within the sidebar definition + some indentation fixes + jsdoc syntax for comments in js
alexytomi
force-pushed
the
Project/Lofty_Pillars
branch
from
4fe32d3 to
db0a034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
From the void of the nonexistent 'Towers' Rework, 'Pillars' is here to replace it! It has been called 'Lofty' because I am of the opinion that this will significantly turn the wiki into a better state in all the ways (except information, that comes after the merge with the way too many changes)
What does this PR change?
The sidebar configuration and in-addition, utilizing the previously unused navbar
The entire folder structure
markdown.Addition of primitive documentation for contributors
What does this all do for the project?
The changes are a move towards a more modern JavaScript ecosystem as well as a simple yet extensible configuration system. I've utilized newer syntax wherever possible and allowed by the old Vuepress v1 system as well as lowered the boilerplate and confusion created by the immense bracket nesting. This should all simplify the edits most often required to be done, apart from editing markdown files themselves.