Skip to content

fix test directory references and resolve linting violations#91

Merged
christianchimezie merged 1 commit into
PlotSenseAICommunity:developfrom
DYung26:chore/fix-test-directory-and-linting
Apr 5, 2026
Merged

fix test directory references and resolve linting violations#91
christianchimezie merged 1 commit into
PlotSenseAICommunity:developfrom
DYung26:chore/fix-test-directory-and-linting

Conversation

@DYung26

@DYung26 DYung26 commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Fixed 143 linting violations across the test suite and corrected directory references in the GitHub Actions workflow to use the correct tests directory instead of the non-existent test directory. These fixes ensure the test suite passes linting checks and the workflow correctly targets the test files for quality checks.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test additions/improvements
  • CI/CD changes
  • Dependencies update

Related Issues

Closes #
Related to # Test suite linting and workflow configuration

Changes Made

  • Updated .github/workflows/python-tests.yml to reference tests/ directory instead of non-existent test/ in pytest commands (3 occurrences)
  • Updated .github/workflows/python-tests.yml flake8 command to lint tests directory instead of test
  • Fixed 137 W293 (blank line contains whitespace) violations across 4 test files by removing trailing whitespace from blank lines
  • Fixed 5 F841 (local variable assigned but never used) violations by either removing unused variable assignments or using underscore convention
  • Fixed 1 W291 (trailing whitespace) violation by removing inline trailing whitespace
  • All test files now pass flake8 linting with 0 violations

Documentation

  • I have updated the README.md (if needed) - Not applicable
  • I have updated TESTING.md (if test-related changes) - Not applicable
  • I have added/updated docstrings for new functions/classes - Not applicable
  • I have updated type hints/annotations - Not applicable
  • I have added comments for complex logic - Not applicable

Checklist

  • I have read the CONTRIBUTING guidelines
  • My branch is up to date with the target branch
  • I have resolved all merge conflicts - No conflicts
  • All CI/CD checks pass
  • Code has been reviewed by me
  • I have tested this on my local environment - Verified flake8 passes on all test files with 0 violations
  • Documentation is updated - No changes needed for test linting fixes
  • Commit messages follow Conventional Commits

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@christianchimezie
christianchimezie merged commit bae5ea5 into PlotSenseAICommunity:develop Apr 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants