Fix CI failures: visual tests and MSVC localtime warning #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linux: run tests under xvfb-run for software OpenGL rendering - macOS/Windows: exclude visual_regression test (no headless GPU) - Fix MSVC C4996 warning: replace std::localtime with localtime_s/_r Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add _CRT_SECURE_NO_WARNINGS for visual test targets on MSVC - Remove decimation_identity from regression runner (uses non-standard two-pass interface incompatible with --output protocol) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
facontidavide
added a commit
that referenced
this pull request
Jan 24, 2026
- Add lineRenderer(), markerRenderer(), textRenderer() accessors (#2) - Integrate PlotLegend into Plot (setLegendVisible, legend()) (#3) - Integrate PlotMarker management (addMarker, removeMarker, clearMarkers) - Integrate CurveTracker (setTrackerEnabled, setTrackerMode, tracker()) - Update render pipeline: curves → markers → tracker → zoom → legend - Route input events to legend and tracker with proper priority - Add 15 unit tests covering all new API surface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary