Fix CI failures on Linux, macOS, and Windows #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linux: Remove qt5-default package from workflow (deprecated in Ubuntu 24.04, qtbase5-dev is sufficient) - macOS/Windows: Add (void) casts to silence unused parameter warnings in plot_exporter.cpp for non-GL backends (-Werror was treating these as errors) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
QOpenGLWidget uses its own internal framebuffer object, not the default framebuffer (0). Sokol was rendering to FBO 0 while Qt was displaying from its internal FBO, causing a black screen. The fix sets pass.swapchain.gl.framebuffer to defaultFramebufferObject() so Sokol renders to Qt's FBO. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
facontidavide
added a commit
that referenced
this pull request
Jan 24, 2026
- Add lineRenderer(), markerRenderer(), textRenderer() accessors (#2) - Integrate PlotLegend into Plot (setLegendVisible, legend()) (#3) - Integrate PlotMarker management (addMarker, removeMarker, clearMarkers) - Integrate CurveTracker (setTrackerEnabled, setTrackerMode, tracker()) - Update render pipeline: curves → markers → tracker → zoom → legend - Route input events to legend and tracker with proper priority - Add 15 unit tests covering all new API surface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
qt5-defaultpackage from workflow (deprecated in Ubuntu 24.04,qtbase5-devis sufficient)(void)casts to silence unused parameter warnings inplot_exporter.cppfor non-GL backends (-Werrorwas treating these as errors)Test plan
🤖 Generated with Claude Code