Documentation for custom tags #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrze
requested changes
Nov 10, 2023
| return_to: /success_page | ||
| --- | ||
|
|
||
| {% form html-novalidate: true, html-class: 'model-form' %} |
There was a problem hiding this comment.
@andrew-3 @diana-lakatos {% form %} tag is deprecated. Instead we should provide example with page that have normal html <form>.
Inside
spam_protection tag or you can enter own code for generating hcaptcha code (https://github.com/Platform-OS/product-marketplace-template/blob/master/app/views/partials/hcaptcha.liquid)In order to validate hcaptcha you can use this function https://github.com/Platform-OS/product-marketplace-template/blob/master/app/views/partials/lib/validations/hcaptcha.liquid
Please do not add examples that use {% form %} tag. We should change all examples that use it.
There was a problem hiding this comment.
@diana-lakatos I've created ticket for it in past, sadly it was closed.....
#1497
andrew-3
force-pushed
the
documentation-for-custom-tags
branch
from
bbabbea to
358c137
Compare
|
@piotrze I've removed from the page those which were only form-specific, and converted the others from the form tag to HTML tags. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.