Conversation
automatically close and lock prs that change more than a single line.
|
gonna do a second take using https://github.com/vloddi/changed-lines-count-labeler to label prs with >= 2 lines changed as |
|
@madrobby fair point, but i think it's a reasonable restriction to put in place that each signature be its own commit, for the sake of making it easier to keep bad actors out. otoh, should be ok to bump the limit to 2 signatures in one pr without decreasing effectiveness. |
|
@jbhannah yeah, agree. (we should check closed PRs occasionally if we missed something; I guess it's sort of like a spam filter in email.) |
|
Typical that while you're working on this we get our first double-signature PR 😆 Anyway, this looks really helpful, it's much appreciated. |
|
deleting unhelpful comments because i find it personally hilarious btw |
|
could lock PRs that delete any lines, since any signatures should be append-only |
shkm
left a comment
There was a problem hiding this comment.
Currently failing due to lack of permissions; I suspect this will resolve it.
Co-authored-by: Jamie Schembri <jamie@schembri.me>
|
... did this PR just close and lock itself? 😆 |
|
lmaoooooo i guess that means it works 🤣 |
|
um …ok so i'm gonna merge and push this to trunk manually |
|
🤣 |
automatically close and lock prs that change more than a single line.