location: rename FLAG_STREAM as FLAG_SIDEEFFECTS - #501
Open
omar-polo wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames the importer flag FLAG_STREAM to FLAG_SIDEEFFECTS to better communicate that the importer is not safe to run multiple times for gathering statistics, while maintaining backward compatibility via an alias and parser support.
Changes:
- Introduce
FLAG_SIDEEFFECTSas the new flag name and keepFLAG_STREAMas an alias for compatibility. - Update
ParseFlagto accept"sideeffects"(and continue accepting"stream").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stream was a bad name, as it doesn't really imply the fact that it's not safe to call the importer twice to gather some statistics. Strictly speaking, all integrations have side effects, even just a network connection is, but it conveys better the idea of "spooky action at a distance" happening. For backward compatibility, add an alias for FLAG_STREAM to FLAG_SIDEEFFECTS and also make ParseFlag accept the new name.
omar-polo
force-pushed
the
op/side-effects
branch
from
July 22, 2026 16:56
2e374d3 to
e2ced5f
Compare
Comment on lines
+127
to
+128
| case "sideeffects", "stream": | ||
| return FLAG_SIDEEFFECTS, nil |
mathieu-plak
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream was a bad name, as it doesn't really imply the fact that it's not safe to call the importer twice to gather some statistics.
Strictly speaking, all integrations have side effects, even just a network connection is, but it conveys better the idea of "spooky action at a distance" happening.
For backward compatibility, add an alias for FLAG_STREAM to FLAG_SIDEEFFECTS and also make ParseFlag accept the new name.