Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry support for document cmdlets #444

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

Szeraax
Copy link

@Szeraax Szeraax commented Oct 9, 2021

Style guide suggests that using splatting is cool, so I also changed some commands with immediate execution to use splatting.

Marking PR as draft.

  • Implements parameters for document cmdlets
  • Implements parameters for Invoke-CosmosDbRequest
  • Does not yet include any unit tests
  • Does not yet include any PlatyPS documentation

@PlagueHO Note: There is no dev branch to open the PR against according to the contrib document. Opening against main.


This change is Reviewable

@PlagueHO
Copy link
Owner

PlagueHO commented Oct 9, 2021

Ah right, looks like I need to update the contrib doc - no longer use dev/master. Changed to main - so all good.

@Szeraax
Copy link
Author

Szeraax commented Oct 9, 2021

I'll look at the tests and platyps stuff next week when I have some more time if you or other don't get to it first.

Loving the module so far! Great work.

@PlagueHO
Copy link
Owner

PlagueHO commented Oct 9, 2021

Just a couple of style/consistency nitpicks:

  • Tend to avoid using type accelerators, so [int] to `[System.Int32]' etc.
  • Use lower case first letter for local variable names.
  • Avoid using generic $splat variable name, rather name with indicator of use (sometimes not possible if used with multiple cmdlets): e.g. $invokeCosmosDbRequest_parameters

I adopted the style and practices we adopted over the PowerShell DSC modules 😁

@Szeraax
Copy link
Author

Szeraax commented Oct 9, 2021

K, I'll go update those.

@PlagueHO
Copy link
Owner

PlagueHO commented Oct 9, 2021

Awesome! Thank you for putting time into this! I've had so little time lately to work on stuff - so much appreciated.

@Szeraax
Copy link
Author

Szeraax commented Oct 9, 2021

Hope you squash PR's on merge for this.

Using this module, I've been able to rapidly prototype an AzureFunctions frontend with Cosmos DB in 2 days that has been plagued by issues in Azure SQL RDMS for months. SOOOO nice being able to just use a JSON document instead of trying to replicate relationships of data across about 7 tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants