Skip to content

fix: Google 로그인 리디렉션 URI 설정 로직 수정 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjangminii merged 2 commits into from
Dec 28, 2025
Merged

fix: Google 로그인 리디렉션 URI 설정 로직 수정 #228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fe37f4
fix: Google 로그인 리디렉션 URI 설정 로직 수정
jjangminii Dec 28, 2025
87cc9fe
chore: 주석
jjangminii Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/client/src/pages/onBoarding/components/funnel/step/SocialLoginStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@ import GoogleLogo from '/assets/onBoarding/icons/googleLogo.svg';
const SocialLoginStep = () => {
const handleGoogleLogin = () => {
const clientId = import.meta.env.VITE_GOOGLE_CLIENT_ID;
const redirectUri = import.meta.env.VITE_GOOGLE_REDIRECT_URI;
// const redirectUri = import.meta.env.VITE_GOOGLE_REDIRECT_URI;

Comment on lines +7 to +8
Copy link

@coderabbitai coderabbitai bot Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

주석 처리된 코드를 제거하세요.

주석 처리된 코드는 버전 관리 시스템에서 관리되므로 파일에 남겨둘 필요가 없습니다. 코드 가독성을 위해 제거하는 것이 좋습니다.

🔎 제안하는 수정 사항 
-    // const redirectUri = import.meta.env.VITE_GOOGLE_REDIRECT_URI;
-
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
// const redirectUri = import.meta.env.VITE_GOOGLE_REDIRECT_URI;
🤖 Prompt for AI Agents 
In apps/client/src/pages/onBoarding/components/funnel/step/SocialLoginStep.tsx
around lines 7-8, remove the commented-out line "// const redirectUri =
import.meta.env.VITE_GOOGLE_REDIRECT_URI;" from the file; delete the commented
code and save the file (then run the project's lint/format step if applicable to
ensure no trailing whitespace or formatting issues).

const redirectUri = import.meta.env.PROD
? import.meta.env.VITE_GOOGLE_REDIRECT_URI_PROD
: import.meta.env.VITE_GOOGLE_REDIRECT_URI_DEV;

console.log('redirectUri:', redirectUri);
Copy link

@coderabbitai coderabbitai bot Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

프로덕션 환경에서 실행되는 console.log를 제거하세요.

OAuth 설정 정보인 리다이렉트 URI를 콘솔에 출력하는 것은 보안상 권장되지 않습니다. 프로덕션 환경에서 설정 정보가 노출될 수 있으며, 이는 잠재적인 보안 위험을 초래할 수 있습니다.

🔎 제안하는 수정 사항

옵션 1 (권장): console.log 제거

-    console.log('redirectUri:', redirectUri);
-

옵션 2: 개발 환경에서만 로깅

-    console.log('redirectUri:', redirectUri);
+    if (import.meta.env.DEV) {
+      console.log('redirectUri:', redirectUri);
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
console.log('redirectUri:', redirectUri);
🤖 Prompt for AI Agents 
In apps/client/src/pages/onBoarding/components/funnel/step/SocialLoginStep.tsx
around line 13, remove the console.log('redirectUri:', redirectUri) that prints
OAuth redirect URIs to the console; either delete the line entirely (preferred)
or replace it with environment-gated logging so it only runs when
process.env.NODE_ENV === 'development' (e.g., use a conditional guard) to avoid
leaking sensitive configuration in production.


if (!clientId || !redirectUri) {
alert('Google OAuth 설정이 누락되었습니다.');
return;
}

const googleAuthUrl =
`https://accounts.google.com/o/oauth2/v2/auth?` +
`client_id=${clientId}` +
Expand Down
Loading