Skip to content

Feat(client): 온보딩 final-step 수정 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jllee000 wants to merge 3 commits into from
Closed

Feat(client): 온보딩 final-step 수정 #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92a96cc
feat: 온보딩 final 스텝 수정
jllee000 Dec 11, 2025
04f5f85
feat: 이미지 포맷 수정
jllee000 Dec 11, 2025
9331388
feat: 이미지 경로 수정
jllee000 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/client/public/assets/onBoarding/icons/ext.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions apps/client/public/assets/onBoarding/icons/pin.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added apps/client/public/assets/onBoarding/story/final.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions apps/client/src/pages/onBoarding/components/funnel/step/FinalStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
import dotori from '/assets/onBoarding/icons/dotori.svg';
import finalImg from '/assets/onBoarding/story/final.webp';
import extImg from '/assets/onBoarding/icons/ext.svg';
import pinImg from '/assets/onBoarding/icons/pin.svg';
const FinalStep = () => {
return (
<div className="flex h-full flex-col items-center">
<img src={dotori} className="mb-[1.2rem]" alt="dotori" />
<p className="head2 text-font-black-1">Pinback에 오신 걸 환영해요</p>
<p className="body2-m text-font-gray-3 mb-[1.4rem] mt-[0.8rem] text-center">
브라우저에서{' '}
<img src={extImg} className="mx-[0.39rem] inline-block" alt="ext" />을
선택한 다음{' '}
<img src={pinImg} className="mx-[0.39rem] inline-block" alt="pin" />을
선택하여 북마크를 빠르게 저장해보세요
</p>
<img src={finalImg} className="" alt="mac" />
Copy link

@coderabbitai coderabbitai bot Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

이미지의 alt 텍스트를 개선하고 불필요한 속성을 제거하세요.

다음 개선사항을 고려해주세요:

  1. 빈 className=""은 불필요하므로 제거
  2. alt 텍스트 "mac"이 이미지 내용을 충분히 설명하지 못함 (예: "온보딩 완료 화면" 등으로 개선)
  3. 명시적인 width/height 속성 추가를 고려하여 레이아웃 시프트 방지

다음 diff를 적용하여 개선할 수 있습니다:

-      <img src={finalImg} className="" alt="mac" />
+      <img src={finalImg} alt="온보딩 완료 화면" />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<img src={finalImg} className="" alt="mac" />
<img src={finalImg} alt="온보딩 완료 화면" />
🤖 Prompt for AI Agents 
In apps/client/src/pages/onBoarding/components/funnel/step/FinalStep.tsx around
line 17, remove the empty className attribute, replace the vague alt="mac" with
a more descriptive alt like "온보딩 완료 화면" (or another succinct Korean description
of the image), and add explicit width and height attributes (or appropriate
layout props) to prevent layout shift; update the JSX accordingly so the element
no longer contains className="" and includes the improved alt plus explicit
dimensions.

</div>
);
};
Expand Down
Loading