Fix question without category is duplicated #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is taken from Pierre-Sassoulas#168, the test is based on fixture from Pierre-Sassoulas#177.
|
Thank you again. Just a passing remark, the name of the PR should be about the actual problem i.e. "Fix question without category being duplicated" and not about the issue i.e. "Fix issue #134", this is easier to understand without context :) Also you can add a "Closes #134" in the description so the issue is automatically closed. |
Pierre-Sassoulas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is taken from #168, the test is based on fixture from #177.