Skip to content

Align complex64 finfo with NumPy #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronaldmannak wants to merge 1 commit into from
Closed

Align complex64 finfo with NumPy #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Source/MLX/DType.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ public enum DType: Hashable, Sendable, CaseIterable {
#else
case .float16: 0x1p-10 // 2^-10
#endif
case .float32: Double(Float.ulpOfOne)
case .float32, .complex64: Double(Float.ulpOfOne)
case .bfloat16: 0x1p-7 // 2^-7 (7 mantissa bits)
case .complex64, .float64: Double.ulpOfOne
case .float64: Double.ulpOfOne
default: fatalError("\(dtype) is not a floating point type")
}
}
Expand All @@ -166,8 +166,8 @@ public enum DType: Hashable, Sendable, CaseIterable {
case .float16: 0x1.FFCp15 // 65504
#endif
case .bfloat16: Double(Float(bitPattern: 0x7F7F_0000)) // bf16 = high 16 bits of f32
case .float32: Double(Float.greatestFiniteMagnitude)
case .complex64, .float64: Double.greatestFiniteMagnitude
case .float32, .complex64: Double(Float.greatestFiniteMagnitude)
case .float64: Double.greatestFiniteMagnitude
default: fatalError("\(dtype) is not a floating point type")
}
}
Expand All @@ -180,9 +180,9 @@ public enum DType: Hashable, Sendable, CaseIterable {
#else
case .float16: 0x1p-14 // 2^-14
#endif
case .float32: Double(Float.leastNormalMagnitude)
case .float32, .complex64: Double(Float.leastNormalMagnitude)
case .bfloat16: 0x1p-126 // 2^-126 (same exponent range as f32)
case .complex64, .float64: Double.leastNormalMagnitude
case .float64: Double.leastNormalMagnitude
default: fatalError("\(dtype) is not a floating point type")
}
}
Expand All @@ -195,9 +195,9 @@ public enum DType: Hashable, Sendable, CaseIterable {
#else
case .float16: 0x1p-24 // 2^-24
#endif
case .float32: Double(Float.leastNonzeroMagnitude)
case .float32, .complex64: Double(Float.leastNonzeroMagnitude)
case .bfloat16: 0x1p-133 // 2^-133 = 2^-126 · 2^-7
case .complex64, .float64: Double.leastNonzeroMagnitude
case .float64: Double.leastNonzeroMagnitude
default: fatalError("\(dtype) is not a floating point type")
}
}
Expand Down