-
Notifications
You must be signed in to change notification settings - Fork 1
Defer table header announcement until separator confirms #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
44c5fdf
fix: streaming correctness and per-chunk performance issues from pack…
claude 4ca0d58
fix: address PR #5 review feedback
claude 3ea77c0
fix: address second round of PR #5 review feedback
claude 643b0a9
ci: test on macOS and iOS Simulator via GitHub Actions
claude 58d7265
fix: make the package compile for iOS (AppKit-only table/HR rendering)
claude 6019ddd
fix: reach TextKit 2 content storage via textLayoutManager on iOS
claude a64f663
test: platform-split the table block-styling assertion
claude 1ae22c7
fix: address Codex re-review findings
claude 828a83e
fix: propagate task cancellation to the image download data task
claude ccbd8ef
fix: cancel shared image downloads when their last waiter cancels
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test-macos: | ||
| name: macOS (swift test) | ||
| runs-on: macos-26 | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # swift-tools-version 6.2 requires Xcode 26; pick the newest installed. | ||
| - name: Select latest Xcode 26 | ||
| run: | | ||
| LATEST=$(ls -d /Applications/Xcode_26*.app 2>/dev/null | sort -V | tail -1 || true) | ||
| if [ -n "$LATEST" ]; then | ||
| sudo xcode-select -s "$LATEST/Contents/Developer" | ||
| fi | ||
| xcodebuild -version | ||
| swift --version | ||
|
|
||
| - name: Cache SwiftPM build | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: .build | ||
| key: spm-macos-${{ hashFiles('Package.resolved') }} | ||
| restore-keys: spm-macos- | ||
|
|
||
| # Benchmarks (PicoMarkdownViewBenchmarks) are excluded: they measure | ||
| # throughput and are meant for local before/after comparisons, not a | ||
| # pass/fail gate on shared runners with noisy neighbors. | ||
| - name: Run tests | ||
| run: swift test --filter PicoMarkdownViewTests | ||
|
|
||
| test-ios: | ||
| name: iOS Simulator (xcodebuild test) | ||
| runs-on: macos-26 | ||
| timeout-minutes: 40 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Select latest Xcode 26 | ||
| run: | | ||
| LATEST=$(ls -d /Applications/Xcode_26*.app 2>/dev/null | sort -V | tail -1 || true) | ||
| if [ -n "$LATEST" ]; then | ||
| sudo xcode-select -s "$LATEST/Contents/Developer" | ||
| fi | ||
| xcodebuild -version | ||
|
|
||
| # Runner images add/remove device types over time, so resolve an | ||
| # available iPhone at runtime instead of hardcoding a name. | ||
| - name: Pick an iPhone simulator | ||
| id: sim | ||
| run: | | ||
| DEVICE=$(xcrun simctl list devices available | grep -m1 'iPhone' | sed -E 's/^[[:space:]]*//; s/[[:space:]]*\(.*$//') | ||
| if [ -z "$DEVICE" ]; then | ||
| echo "No available iPhone simulator found" >&2 | ||
| xcrun simctl list devices >&2 | ||
| exit 1 | ||
| fi | ||
| echo "Using simulator: $DEVICE" | ||
| echo "device=$DEVICE" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| set -o pipefail | ||
| xcodebuild test \ | ||
| -scheme PicoMarkdownView \ | ||
| -destination "platform=iOS Simulator,name=${{ steps.sim.outputs.device }}" \ | ||
| -only-testing:PicoMarkdownViewTests \ | ||
| -resultBundlePath TestResults.xcresult \ | ||
| CODE_SIGNING_ALLOWED=NO | ||
|
|
||
| - name: Upload result bundle on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ios-test-results | ||
| path: TestResults.xcresult | ||
| if-no-files-found: ignore | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.