Skip to content

#268 fix e2e bug #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilipWoulfe merged 1 commit into from
Jul 9, 2026
+17 −1
Merged

#268 fix e2e bug #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion tests/F1.E2E.Tests/Pages/HomePage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@ namespace F1.E2E.Tests.Pages;

internal class HomePage
{
private static readonly string[] AuthenticatedNavigationSelectors =
[
"a[href='results']",
"a[href='/results']",
"a[href='drivers']",
"a[href='/drivers']",
"a[href='selection']",
"a[href='/selection']",
"a[href^='selection/']",
"a[href^='/selection/']",
"a[href='admin']",
"a[href='/admin']",
"a[href='admin/migration-runs']",
"a[href='/admin/migration-runs']"
];

private readonly IWebDriver _driver;
private readonly WebDriverWait _wait;
private readonly string _baseUrl;
Expand All @@ -32,7 +48,7 @@ public void WaitForAuthenticatedNavigation()
PageReadiness.WaitForAppReady(
_driver,
_wait.Timeout,
driver => driver.FindElements(By.CssSelector("a[href^='selection/']")).Count > 0);
driver => AuthenticatedNavigationSelectors.Any(selector => driver.FindElements(By.CssSelector(selector)).Count > 0));
_trace("Authenticated navigation link rendered.");
}

Expand Down
Loading