Bugfix/#275 migration preseason issues - #281
Merged
Merged
Conversation
added 3 commits
July 7, 2026 14:37
…ected variance manifest path behavior
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses preseason-related migration issues for the Phil 2025 CSV contract by ensuring preseason policy/tallies are available for scoring, normalizing preseason question keys across source offsets, and improving reconciliation matching so preseason diffs align correctly.
Changes:
- Adds/updates migration tests covering Phil 2025 preseason policy-driven scoring and reconciliation matching by
(QuestionKey, Subject). - Updates
MigrationReconciliationServiceandMigrationLegacyScoreImporterto normalize preseason question keys and reconcile rows with differing source offsets. - Updates worker packaging/docs (Dockerfile + README) and E2E page object tab/pane selectors for the migration runs UI.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/F1.Infrastructure.Tests/Relational/MigrationImportRunServiceTests.cs | Adds an end-to-end-ish relational test for preseason scoring with Phil policy; adjusts test importer behavior. |
| tests/F1.Infrastructure.Tests/Contracts/MigrationScoreRecalculatorTests.cs | Adds a targeted test for preseason exact scoring when Phil policy is present. |
| tests/F1.Infrastructure.Tests/Contracts/MigrationReconciliationServiceTests.cs | Adds coverage ensuring preseason rows with different source offsets reconcile by key/subject. |
| tests/F1.Infrastructure.Tests/Contracts/MigrationRaceSelectionParserTests.cs | Tightens assertions around preseason answer normalization for a participant. |
| tests/F1.Infrastructure.Tests/Contracts/MigrationLegacyScoreImporterTests.cs | Updates expected preseason question key mapping for Phil 2025 contract. |
| tests/F1.E2E.Tests/Pages/MigrationRunsPage.cs | Refactors page object to use tab panes and ensures correct tab selection for waits. |
| src/F1.DataSyncWorker/Services/MigrationReconciliationService.cs | Changes preseason diff keying/matching to use (QuestionKey, Subject) and improves ordering/row selection. |
| src/F1.DataSyncWorker/Services/MigrationLegacyScoreImporter.cs | Normalizes preseason question keys for Phil 2025 points rows via contract offset mapping. |
| src/F1.DataSyncWorker/Services/MigrationImportOrchestrator.cs | Adjusts execution order so preseason policy is imported before scoring. |
| src/F1.DataSyncWorker/Dockerfile | Bundles data/imports/phil-2025 into the worker image at runtime. |
| README.md | Documents container-bundled import files and how to override with host-managed files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.