Skip to content

feat: add support for overriding title and level through CLI params #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naptie merged 4 commits into from
Dec 29, 2025
Merged

feat: add support for overriding title and level through CLI params #40

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce5b5ba
Initial plan
Copilot Dec 29, 2025
fc5e579
feat: add support for overriding title and level through CLI params
Copilot Dec 29, 2025
8540a20
refactor: extract metadata override logic into reusable function
Copilot Dec 29, 2025
66a6214
chore: update .gitignore
Naptie Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions src/routes/(app)/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,19 @@
let automate = checkParam('automate', ['1', 'true']);
let overrideTitle: string | undefined;
let overrideLevel: string | undefined;
const applyMetadataOverrides = (bundle: ChartBundle) => {
if (overrideTitle !== undefined) {
bundle.metadata.title = overrideTitle;
}
if (overrideLevel !== undefined) {
bundle.metadata.level = overrideLevel;
bundle.metadata.levelType = inferLevelType(overrideLevel);
}
};
const unlistens: UnlistenFn[] = [];
onMount(async () => {
Expand Down Expand Up @@ -392,6 +405,8 @@
if (args['toggles']) tgs = args['toggles'];
if (args['mediaOptions']) mopts = args['mediaOptions'];
automate = args['automate'] === 'true';
if (args['title']) overrideTitle = args['title'];
if (args['level']) overrideLevel = args['level'];
}
pref ??= localStorage.getItem('preferences');
Expand Down Expand Up @@ -829,15 +844,20 @@
illustration: illustrationFile.id,
metadata: metadataEntry
? {
title: metadataEntry.name,
title: overrideTitle ?? metadataEntry.name,
composer: metadataEntry.composer,
charter: metadataEntry.charter,
illustrator: metadataEntry.illustration ?? null,
level: metadataEntry.level,
levelType: inferLevelType(metadataEntry.level),
level: overrideLevel ?? metadataEntry.level,
levelType: inferLevelType(overrideLevel ?? metadataEntry.level),
difficulty: null,
}
: metadata!,
: {
...metadata!,
title: overrideTitle ?? metadata!.title,
level: overrideLevel ?? metadata!.level,
levelType: overrideLevel ? inferLevelType(overrideLevel) : metadata!.levelType,
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition overrideLevel ? inferLevelType(overrideLevel) : metadata!.levelType uses a truthy check which could be problematic if overrideLevel is an empty string. Empty strings are falsy in JavaScript, so an empty string override would incorrectly fall back to the original levelType. Consider using overrideLevel !== undefined instead to match the pattern used in line 227 of the helper function.

Suggested change
levelType: overrideLevel ? inferLevelType(overrideLevel) : metadata!.levelType,
levelType: overrideLevel !== undefined ? inferLevelType(overrideLevel) : metadata!.levelType,

Copilot uses AI. Check for mistakes.
},
};
chartBundles.push(bundle);
chartBundles = chartBundles;
Expand Down Expand Up @@ -1297,6 +1317,7 @@
}
if (chartBundles.length > 0 && selectedBundle === -1) {
currentBundle = chartBundles[0];
applyMetadataOverrides(currentBundle);
selectedBundle = currentBundle.id;
selectedSong = currentBundle.song;
selectedChart = currentBundle.chart;
Expand Down Expand Up @@ -1777,6 +1798,7 @@
class="transition hover:brightness-75"
onclick={() => {
currentBundle = bundle;
applyMetadataOverrides(currentBundle);
selectedBundle = bundle.id;
selectedChart = bundle.chart;
selectedSong = bundle.song;
Expand Down Expand Up @@ -1805,8 +1827,9 @@
aria-label="Delete"
onclick={() => {
chartBundles = chartBundles.filter((b) => b.id !== bundle.id);
if (selectedBundle === bundle.id) {
if (selectedBundle === bundle.id && chartBundles.length > 0) {
currentBundle = chartBundles[0];
applyMetadataOverrides(currentBundle);
selectedBundle = chartBundles[0].id;
selectedChart = chartBundles[0].chart;
selectedSong = chartBundles[0].song;
Expand Down Expand Up @@ -1878,6 +1901,7 @@
<input
type="text"
bind:value={currentBundle.metadata.title}
disabled={overrideTitle !== undefined}
class="form-input py-3 px-4 block w-full border-gray-200 shadow-sm rounded-lg text-sm focus:z-10 transition hover:border-blue-500 hover:ring-blue-500 focus:border-blue-500 focus:ring-blue-500 disabled:opacity-50 disabled:pointer-events-none bg-base-100 dark:border-neutral-700 dark:text-neutral-300 dark:placeholder-neutral-500 dark:focus:ring-neutral-600"
/>
</div>
Expand Down Expand Up @@ -1943,6 +1967,7 @@
<input
type="text"
bind:value={currentBundle.metadata.level}
disabled={overrideLevel !== undefined}
class="form-input py-3 px-4 block w-full border-gray-200 shadow-sm rounded-lg text-sm focus:z-10 transition hover:border-blue-500 hover:ring-blue-500 focus:border-blue-500 focus:ring-blue-500 disabled:opacity-50 disabled:pointer-events-none bg-base-100 dark:border-neutral-700 dark:text-neutral-300 dark:placeholder-neutral-500 dark:focus:ring-neutral-600"
/>
</div>
Expand Down