import emoji in the hackiest way possible #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #10 in a very weird-ish and hacky way. It works, but its not pretty and is an MVP
I uploaded all the emoji to my minio server. When a user executes
/import-emoji <emojiname>s3 is searched for that path and if it sees it, it grabs it, encodes it to base64 per discord's requirements and shoves it up to discord for the server to use.fun fact: discord doesn't let you have hyphens in an emoji name, so when uploading it I also convert hyphens to underscore in the emoji name.
Things that would make this better: