Extra tests for array/list slices in scalar context #23481
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Jul 27, 2025
t/op/array.t
Outdated
| # GH #23447 - ensure that future optimizations don't break behaviour | ||
| { | ||
| my @x = "a" .. "d"; sub f {} my $y = @x[2, 3, f()]; | ||
| is $y, d, 'Non-returning final sub element in array slice in scalar context'; |
There was a problem hiding this comment.
It might not have "return" but it does return an empty list.
Maybe "Empty list returning final sub element..."
There was a problem hiding this comment.
How about the changed text: "Trailing empty list return in..."?
jkeenan
reviewed
Jul 28, 2025
jkeenan
requested changes
Jul 28, 2025
richardleach
force-pushed
the
LAslice_tests
branch
from
004a040 to
7c46b31
Compare
jkeenan
approved these changes
Jul 28, 2025
tonycoz
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small number of extra tests off the back of #23447.