Skip to content

UCD.pm: Add check for parameter type #23301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: blead
Choose a base branch
from
Open

UCD.pm: Add check for parameter type #23301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33aa14d
UCD.pm: Add check for parameter type
khwilliamson May 18, 2025
afe0028
UCD.pm: Unit test for new error condition
jkeenan May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charclass_invlists.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456662,7 +456662,7 @@ static const U8 WB_dfa_table[] = {
#endif /* defined(PERL_IN_REGEXEC_C) */

/* Generated from:
* 6cbf3f0fc04bbb22420eb9689126b5030bd714ad06397d0904702714feabe28e lib/Unicode/UCD.pm
* 2646270ff0dac23e79b18846d33918fba25b80b624e613a69accc3c0f9a0f51b lib/Unicode/UCD.pm
* 764f420cedfc8b43d9fec251c957a5d55fc45d40f6573f162990ed1dce7e36e0 lib/unicore/ArabicShaping.txt
* b8f32554c6f658821fb0ee742d21c5b1f2086b9bf13071fed04894b022f93d67 lib/unicore/BidiBrackets.txt
* d7afdadd1bbd66f5a663ac0e8f7958f18fd9491fc0bc59ec5877cb82db71db7d lib/unicore/BidiMirroring.txt
Expand Down
2 changes: 2 additions & 0 deletions lib/Unicode/UCD.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,6 +2533,8 @@ change these into digits, and then call C<num> on the result.

sub num ($;$) {
my ($string, $retlen_ref) = @_;
croak __PACKAGE__, "::num: second parameter must be a scalar reference"
if defined $retlen_ref && ref $retlen_ref ne "SCALAR";

use feature 'unicode_strings';

Expand Down
7 changes: 7 additions & 0 deletions lib/Unicode/UCD.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,13 @@ is($ret_len, 5, "... and the returned length is 5");
ok(! defined num("98765\N{FULLWIDTH DIGIT FOUR}", \$ret_len),
'Verify num("98765\N{FULLWIDTH DIGIT FOUR}") isnt defined');
is($ret_len, 5, "... but the returned length is 5");
{
local $@;
my $ret_len = [ 5 ];
eval { num("98765", \$ret_len); };
like($@, qr/::num: second parameter must be a scalar reference/,
"num: Incorrect type for second parameter; must be scalar ref");
}
my $tai_lue_2;
if ($v_unicode_version ge v4.1.0) {
my $tai_lue_1 = charnames::string_vianame("NEW TAI LUE DIGIT ONE");
Expand Down
2 changes: 1 addition & 1 deletion lib/unicore/uni_keywords.pl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion regcharclass.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion regexp_constants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#define MAX_FOLD_FROMS 3

/* Generated from:
* 6cbf3f0fc04bbb22420eb9689126b5030bd714ad06397d0904702714feabe28e lib/Unicode/UCD.pm
* 2646270ff0dac23e79b18846d33918fba25b80b624e613a69accc3c0f9a0f51b lib/Unicode/UCD.pm
* 764f420cedfc8b43d9fec251c957a5d55fc45d40f6573f162990ed1dce7e36e0 lib/unicore/ArabicShaping.txt
* b8f32554c6f658821fb0ee742d21c5b1f2086b9bf13071fed04894b022f93d67 lib/unicore/BidiBrackets.txt
* d7afdadd1bbd66f5a663ac0e8f7958f18fd9491fc0bc59ec5877cb82db71db7d lib/unicore/BidiMirroring.txt
Expand Down
2 changes: 1 addition & 1 deletion uni_keywords.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading