Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 32-bit Swift (arm) #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for 32-bit Swift (arm) #4

wants to merge 1 commit into from

Conversation

hpux735
Copy link

@hpux735 hpux735 commented Oct 6, 2016

These changes are a bit ugly. The issue with INADDR_CONST is that I have to tell Swift very explicitly (this feels like a swift bug to me) the bit pattern type. The literal constant is stubbornly interpreted as a Int, which being 32-bit, would overflow (swift protects the sign bit).

The change to NetTCPSSL.swift is because the api is slightly different. So, this just traps the arm case and coerces the type.

@petershaw
Copy link

The changes in Sources/NetTCP.swift will not work on 4.1, but the changes in Sources/NetTCPSSL.swift saved my day. This should be merged.
Can you please clean up the commit and so a new merge request? Than, Perfect will work on Raspi's too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants