WIP: Automate operator release #320
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A few points:
|
egegunes
reviewed
Oct 25, 2024
tools/operator-tool/README.md
Outdated
Comment on lines
28
to
34
| $ ./bin/operator-tool --operator "psmdb-operator" --version "1.17.0" # outputs source file for psmdb-operator | ||
| ... | ||
| $ ./bin/operator-tool --operator "pg-operator" --version "2.5.0" # outputs source file for pg-operator | ||
| ... | ||
| $ ./bin/operator-tool --operator "ps-operator" --version "0.8.0" # outputs source file for ps-operator | ||
| ... | ||
| $ ./bin/operator-tool --operator "pxc-operator" --version "1.15.1" # outputs source file for pxc-operator |
There was a problem hiding this comment.
since the flag is already --operator maybe we can just use --operator psmdb or --operator pxc, wdyt?
|
|
|
|
|
|
|
|
jvpasinatto
requested changes
Jan 14, 2025
| } | ||
|
|
||
| func PSMDB(f *filler.VersionFiller, version string) (*vsAPI.VersionMatrix, error) { | ||
| mongoVersions, err := productsapi.GetProductVersions("percona-server-mongodb-", "percona-server-mongodb-7.0", "percona-server-mongodb-6.0", "percona-server-mongodb-5.0") |
There was a problem hiding this comment.
please include mongo 8.0
| return nil, err | ||
| } | ||
|
|
||
| xtrabackupVersions, err := productsapi.GetProductVersions("Percona-XtraBackup-", "Percona-XtraBackup-8.0", "Percona-XtraBackup-2.4") |
There was a problem hiding this comment.
please include pxc 8.4
| ) | ||
|
|
||
| func PG(f *filler.VersionFiller, version string) (*vsAPI.VersionMatrix, error) { | ||
| pgVersions, err := productsapi.GetProductVersions("", "postgresql-distribution-16", "postgresql-distribution-15", "postgresql-distribution-14", "postgresql-distribution-13", "postgresql-distribution-12") |
| @@ -0,0 +1,75 @@ | |||
| # operator-tool | |||
There was a problem hiding this comment.
please use ticket CLOUD-861 in PR
|
|
||
| import "strings" | ||
|
|
||
| func GetArchSuffixes() []string { |
There was a problem hiding this comment.
we actually only need -multi for now
| // Logic: | ||
| // - If an image supports both amd64 and arm64 architectures and has a "-multi" suffix in its tag, | ||
| // the function includes a version of the image tag without the "-multi" suffix in the map. | ||
| // - If no image with both amd64 and arm64 builds is found, separate images for amd64 and arm64 |
There was a problem hiding this comment.
we don't need separated images for arm64 and amd64, as we don't need arm64 images individually.
When a image does not have arm64, just provide the it's tag with only amd64 hash.
| Specify an older source file. The operator-tool will exclude any versions that are older than those listed in this file | ||
| -include-arch-images | ||
| Include images with "-multi", "-arm64", "-aarch64" suffixes in the output file | ||
| -only-latest |
There was a problem hiding this comment.
I'm using ./bin/operator-tool -operator psmdb --version 1.19.0 --only-latest --include-arch-images --file sources/operator.1.18.0.psmdb-operator.json
This makes backup, operator and pmm have 2 images, but ideally we want just the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new binary,
operator-tool, which automates the generation of source files for operators.See README.md for more details.
Still to be done (could be addressed in future PRs):
api-testsdirectory*.dep.jsonfiles