Fixed issue #434 #435
Open
Fixed issue #434 #435
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
.-. I'll take my pull down, no point in us both committing. |
Cheers mate - fix might take a while to merge anyways since Jack (potts99) is taking a short break |
ners
reviewed
Mar 18, 2025
| @@ -49,7 +49,7 @@ export default function Tickets() { | |||
| <div className="flex flex-col"> | |||
| <div className="py-2 px-6 flex flex-row items-center justify-between bg-gray-200 dark:bg-[#0A090C] border-b-[1px]"> | |||
| <span className="text-sm font-bold"> | |||
| You have {data.tickets.length} closed ticket | |||
| You have {data.tickets.length} closed tickets. | |||
There was a problem hiding this comment.
This doesn't look right. Notice the logic for appending an s in the next line.
If we have multiple tickets, the string you're building will be "You have n closed tickets.s"
There was a problem hiding this comment.
honestly. I really dont know typescript just thought English was English when it came to text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #434 of a grammatical error mistake