Fix Jax bump upgrading numpy as well #1369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidnhm
added
the
ci:build-all-qml-demos
|
FYI @rashidnhm I'm 99% sure we don't need this anymore, particularly as we are now switching to the V2 pipeline, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Temp workaround for pinning numpy outside of poetry
Summary:
Currently, catalyst is hard pinning JAX 0.4.28. But upgrading it also upgrades numpy to 2.x which is breaking matplotlib.
Relevant references:
[sc-91141]
Previous Failure
Possible Drawbacks:
We need to roll this back prior to next release.
Related GitHub Issues:
None.