Skip to content

[Bug Fix] Higher order Trotter product for CDF Hamiltonian #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 28, 2025
Merged

[Bug Fix] Higher order Trotter product for CDF Hamiltonian #1354

merged 11 commits into from
Apr 28, 2025

Conversation

obliviateandsurrender
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender commented Apr 21, 2025 •
edited
Loading

Fixes the higher order Trotter product for CDF Hamiltonian demo.

[sc-88945]

@github-actions GitHub Actions
Copy link

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2025 •
edited
Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1354
  • Deployment SHA: 4e34d8b67b6270b4be11fc4cbda7ebaa3bbd66c7
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

soranjh
soranjh reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @obliviateandsurrender for fixing this. How do you make sure the current version is bug free and the final results are correct?

@obliviateandsurrender
Copy link
Contributor Author

@soranjh I have separately tested this for other molecules for larger time scales as well, and cross-checked the circuit structure obtained here by manually creating a compatible CDF-based Trotter routine.

soranjh
soranjh approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @obliviateandsurrender.

CatalinaAlbornoz
CatalinaAlbornoz approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@CatalinaAlbornoz CatalinaAlbornoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview looks good.

@obliviateandsurrender obliviateandsurrender merged commit 22863a1 into master Apr 28, 2025
14 checks passed
@obliviateandsurrender obliviateandsurrender deleted the cdf-bugfix branch April 28, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatalinaAlbornoz CatalinaAlbornoz CatalinaAlbornoz approved these changes

@soranjh soranjh soranjh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obliviateandsurrender @CatalinaAlbornoz @soranjh