Move contents of pennylane.utils to appropriate modules
#6588
+394
−508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
reviewed
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
| @@ -2346,7 +2345,7 @@ def eigvals(self): | |||
| standard_observables = {"PauliX", "PauliY", "PauliZ", "Hadamard"} | |||
|
|
|||
| # observable should be Z^{\otimes n} | |||
| self._eigvals_cache = pauli_eigs(len(self.wires)) | |||
| self._eigvals_cache = qml.pauli.pauli_eigs(len(self.wires)) | |||
There was a problem hiding this comment.
Note that Tensor is getting removed by @lillian542 , so there will be a merge conflict.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6588 +/- ##
==========================================
- Coverage 99.29% 99.29% -0.01%
==========================================
Files 454 453 -1
Lines 43264 43248 -16
==========================================
- Hits 42961 42945 -16
Misses 303 303 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The legacy remains
qml.utilsmodule has been hanging around for long. Now, finally we are to delete them and move the remaining folks to wherever they're supposed to be.Specifically, the
following 4 sets of functions have been either moved or removed:
qml.utils._flatten,qml.utils.unflattenhas been moved and renamed toqml.pytrees.flatten_npandqml.pytrees.unflatten_nprespectively.qml.utils._inv_dictandqml._get_default_argshave been removed.qml.utils.pauli_eigshas been moved toqml.pauli.utils.qml.utils.expand_vectorhas been moved toqml.math.expand_vector.Description of the Change:
Benefits:
Less redundancy
Possible Drawbacks:
Rare chance that some downstreaming repo might be using these funcationalities:
We will come back to check them one by one to make sure nothing is to break
Related GitHub Issues:
Related Shortcut Stories:
[sc-76906]