-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch dynamic_one_shot for single shot case #6149
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.38.0-rc0 #6149 +/- ##
==============================================
Coverage ? 99.66%
==============================================
Files ? 445
Lines ? 42362
Branches ? 0
==============================================
Hits ? 42220
Misses ? 142
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to test the 1-sample case in a few spots. Looks good to me, thanks @albi3ro .
Context:
Dynamic one shot was raising an error in the case of a single shot.
Description of the Change:
Adding back in a dimension if the samples have an empty shape before the line that was raising the error.
Benefits:
That particular error no longer occurs.
Possible Drawbacks:
Other parts of the logic might also give errors due to the squeezed nature of samples when created with a single shot. But for the sake of simplicity, I just focused on patching the case we knew lead to an error.
Related GitHub Issues:
[sc-69687] Fixes #6036