Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch dynamic_one_shot for single shot case #6149

Merged
merged 8 commits into from
Aug 29, 2024
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Aug 26, 2024

Context:

Dynamic one shot was raising an error in the case of a single shot.

Description of the Change:

Adding back in a dimension if the samples have an empty shape before the line that was raising the error.

Benefits:

That particular error no longer occurs.

Possible Drawbacks:

Other parts of the logic might also give errors due to the squeezed nature of samples when created with a single shot. But for the sake of simplicity, I just focused on patching the case we knew lead to an error.

Related GitHub Issues:

[sc-69687] Fixes #6036

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v0.38.0-rc0@e84705b). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.38.0-rc0    #6149   +/-   ##
==============================================
  Coverage               ?   99.66%           
==============================================
  Files                  ?      445           
  Lines                  ?    42362           
  Branches               ?        0           
==============================================
  Hits                   ?    42220           
  Misses                 ?      142           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812 mudit2812 added this to the v0.38 milestone Aug 27, 2024
@albi3ro albi3ro requested a review from mudit2812 August 29, 2024 15:25
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to test the 1-sample case in a few spots. Looks good to me, thanks @albi3ro .

@mudit2812 mudit2812 added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Aug 29, 2024
@mudit2812 mudit2812 enabled auto-merge (squash) August 29, 2024 22:01
@mudit2812 mudit2812 merged commit 153b9ef into v0.38.0-rc0 Aug 29, 2024
39 checks passed
@mudit2812 mudit2812 deleted the single-shot-mcm-fix branch August 29, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-ready ✔️ All tests pass and the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants