Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Kokkos arg test fix for MacOS #974

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Nov 4, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-77516]

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @josephleekl

@josephleekl josephleekl marked this pull request as ready for review November 4, 2024 21:29
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.53%. Comparing base (06043d8) to head (24d2207).
Report is 1 commits behind head on v0.39.0_rc.

❗ There is a different number of reports uploaded between BASE (06043d8) and HEAD (24d2207). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (06043d8) HEAD (24d2207)
11 4
Additional details and impacted files
@@               Coverage Diff               @@
##           v0.39.0_rc     #974       +/-   ##
===============================================
- Coverage       97.03%   28.53%   -68.51%     
===============================================
  Files             255       28      -227     
  Lines           38096     2513    -35583     
===============================================
- Hits            36967      717    -36250     
- Misses           1129     1796      +667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD merged commit cf828ac into v0.39.0_rc Nov 4, 2024
113 of 122 checks passed
@multiphaseCFD multiphaseCFD deleted the LK-mac-argtest-fix branch November 4, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants