Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LT docs #971

Merged
merged 7 commits into from
Nov 4, 2024
Merged

update LT docs #971

merged 7 commits into from
Nov 4, 2024

Conversation

multiphaseCFD
Copy link
Member

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD added bug-fix Indicates this fixes a known bug ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Nov 2, 2024
@multiphaseCFD multiphaseCFD marked this pull request as ready for review November 2, 2024 00:34
@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (976baf6) to head (abc5127).
Report is 3 commits behind head on v0.39.0_rc.

Additional details and impacted files
@@              Coverage Diff               @@
##           v0.39.0_rc     #971      +/-   ##
==============================================
- Coverage       97.95%   94.44%   -3.51%     
==============================================
  Files             255      104     -151     
  Lines           38096    15169   -22927     
==============================================
- Hits            37316    14326   -22990     
- Misses            780      843      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD added the do not merge Do not merge PR until this label is removed label Nov 2, 2024
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @multiphaseCFD
A simple question. Could you explain a bit more why this change, please?

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @multiphaseCFD! 🥳

.github/CHANGELOG.md Outdated Show resolved Hide resolved
tests/test_gates.py Outdated Show resolved Hide resolved
doc/lightning_tensor/device.rst Outdated Show resolved Hide resolved
@multiphaseCFD multiphaseCFD merged commit 449579b into v0.39.0_rc Nov 4, 2024
49 of 50 checks passed
@multiphaseCFD multiphaseCFD deleted the fix_qml_state_lt branch November 4, 2024 15:51
@multiphaseCFD multiphaseCFD changed the title Fix qml.state() support for LT update LT docs Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Indicates this fixes a known bug ci:use-gpu-runner Enable usage of GPU runner for this Pull Request do not merge Do not merge PR until this label is removed urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants