Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v0.39.0 RC branch. #969

Closed
wants to merge 20 commits into from
Closed

Create v0.39.0 RC branch. #969

wants to merge 20 commits into from

Conversation

multiphaseCFD
Copy link
Member

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

multiphaseCFD and others added 3 commits October 28, 2024 17:11
### Before submitting

Please complete the following checklist when submitting a PR:

- [X] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [X] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**
This PR fixes Lightning Kokkos with Catalyst failing due to wrong build
path supplied to `setup.py` and lightning kokkos in editable mode.

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

[sc-77123]
### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [x] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

[SC-73065]

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
@multiphaseCFD multiphaseCFD added the do not merge Do not merge PR until this label is removed label Nov 1, 2024
@multiphaseCFD multiphaseCFD added ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Nov 1, 2024
@multiphaseCFD multiphaseCFD marked this pull request as ready for review November 1, 2024 16:18
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 99.21514% with 17 lines in your changes missing coverage. Please review.

Project coverage is 97.03%. Comparing base (5f70b06) to head (dcea959).

Files with missing lines Patch % Lines
pennylane_lightning/lightning_gpu/lightning_gpu.py 22.22% 14 Missing ⚠️
pennylane_lightning/core/lightning_base.py 0.00% 1 Missing ⚠️
...s/lightning_gpu/catalyst/LightningGPUSimulator.hpp 95.00% 1 Missing ⚠️
...ane_lightning/lightning_kokkos/lightning_kokkos.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           v0.39.0_base     #969      +/-   ##
================================================
+ Coverage         96.98%   97.03%   +0.05%     
================================================
  Files               215      255      +40     
  Lines             31857    38096    +6239     
================================================
+ Hits              30896    36967    +6071     
- Misses              961     1129     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: Ali Asadi <[email protected]>
@multiphaseCFD multiphaseCFD requested a review from a team November 4, 2024 15:53
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good.
edit: not considering the CIs errors.

@multiphaseCFD
Copy link
Member Author

Have to update device.rst for LT

### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**
@maliasadi
Copy link
Member

I'll check AARCH64 v0.39.0-rc1 wheels

@multiphaseCFD
Copy link
Member Author

Confirmed LGPU and LT wheels on X86_64 work

DSGuala and others added 2 commits November 4, 2024 13:49
### Before submitting

**Context:**
Lightning tensor docs did not describe installation via `pip install`


**Description of the Change:**

- Added instruction to `pip install cutensornet-cu12` and `pip install
pennylane-lightning-tensor`
- Added warning about installing from source.

**Benefits:**
Clearer installation docs.

**Possible Drawbacks:**
Duplication of information in docs and pennylane.ai/install

**Related GitHub Issues:**

---------

Co-authored-by: ANTH0NY <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
multiphaseCFD and others added 5 commits November 4, 2024 20:02
### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:**

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**
@maliasadi
Copy link
Member

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request do not merge Do not merge PR until this label is removed urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants