Add adjoint lowering pattern for PPR op #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul0403
commented
Nov 21, 2025
paul0403
commented
Nov 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 93 93
Lines 10890 10890
Branches 1038 1038
=======================================
Hits 10617 10617
Misses 211 211
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lazypanda10117
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When a user places a PPR op in an adjoint qfunc (see #2145 ), the
--adjoint-loweringpass will not correctly distribute the adjoint into the region onto PPRs, because the pass does not recognize PPRs.Description of the Change:
Add pattern for PPR ops in adjoint lowering pass.
Benefits:
Correct behavior
Possible Drawbacks:
None