Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the "seeding samples is currently not supported" line in documentation #1178

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Delete the "seeding samples is currently not supported" line in documentation #1178

merged 1 commit into from
Oct 4, 2024

Conversation

paul0403
Copy link
Contributor

@paul0403 paul0403 commented Oct 4, 2024

#1164 forgot to update this line in the public facing documentation

@paul0403 paul0403 requested a review from a team October 4, 2024 14:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

joeycarter
joeycarter approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🚀

@paul0403 paul0403 merged commit d0ac09c into main Oct 4, 2024
45 checks passed
@paul0403 paul0403 deleted the seed_sample_doc branch October 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzunghanjuang tzunghanjuang tzunghanjuang approved these changes

@joeycarter joeycarter joeycarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul0403 @joeycarter @tzunghanjuang