Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-create md/notes editor iframe when navigating #609

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

kevodwyer
Copy link
Member

The fix was done as mathJAX was erroring when initialised more then once on the same page

@kevodwyer kevodwyer closed this Aug 26, 2024
@kevodwyer kevodwyer reopened this Aug 26, 2024
Copy link
Member

@ianopolous ianopolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to understand the consequences of this. Do resizes not work now? Is it slower to navigate to md links? Is there no way to catch the mathjax error? What about not showing the not found error?

@kevodwyer
Copy link
Member Author

I'd like to understand the consequences of this.
Do resizes not work now?
Yes resize works fine. Not an issue

Is it slower to navigate to md links?
No noticeable slow down

Is there no way to catch the mathjax error?
No. Also wouldn't help as that is a symptom not the cause.

What about not showing the not found error?
that was an existing issue that is now fixed

@ianopolous ianopolous merged commit 27f7270 into master Sep 2, 2024
6 checks passed
@kevodwyer kevodwyer deleted the fix/md-editor-mathjax branch September 17, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants