Quadratic Fit actually works now #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot actually goes to the left(and documentation says so) but the code comments and driver hub text mistakenly call that it goes to the right leading to confusion. This fixes this typo.
Fix direction typo(change right to left) in Lateral Zero Power Acceleration tuner.
… second close (Pedro-Pathing#43) * Add workflows to auto-close, reopen, and lock PRs Introduces three GitHub Actions workflows: one to automatically close PRs that add new files and label them as 'mistake-pr', another to allow the PR author to reopen such PRs once via a comment, and a third to permanently lock PRs after a second closure. These workflows help enforce repository contribution policies and streamline PR management. * exclude .github chnages from mistake PR auto-close * Update mistake-pr.yml * Fix reopen guard and permanently lock PR after second close * Fix duplicate comments, copied file detection, and finalize mistake PR logic * Fix reopen state guard and prevent locking merged PRs * Make reopen retry-safe and ignore merged PRs * test: add file to trigger mistake-pr * Revert "test: add file to trigger mistake-pr" This reverts commit c77f92c. * Improve PR locking and mistake detection workflows Enhances the GitHub Actions workflows to better handle permanently locked PRs and mistake PR detection. Adds explicit comments and stricter enforcement for PRs that are reopened after being locked, and improves messaging and logic for automatically closing PRs that add new files. * Add admin override and improve PR lock workflows Introduces an admin override workflow to allow maintainers to bypass the mistake-PR lock on pull requests. Updates existing workflows to support the new 'admin-overridden' label, refines logic for locking and reopening PRs, and improves comments and label handling for clarity and robustness. * Make PR lock and comment idempotent in workflow Update the lock-after-second-close workflow to only add a lock comment and lock the PR if it is not already locked. This prevents duplicate comments and redundant lock actions on already locked PRs. * Remove lock labels on admin override workflow Adds logic to remove 'reopen-locked', 'reopen-used', and 'mistake-pr' labels when an admin override is applied, allowing admins to bypass permanent locks. Updates the override comment to reflect label cleanup. * Revert "Admin override" * Refactor PR mistake handling workflows Simplifies and clarifies the logic for auto-closing, reopening, and permanently locking pull requests that add new files. Updates workflows to reduce race conditions, improve comments, and ensure correct label handling. Switches to pull_request_target for better permission handling and streamlines the process for detecting and managing mistake PRs. * Replace PR lock workflow with disable auto-reopen workflow Removed the workflow that permanently locks PRs after a second close and added a new workflow that disables automatic reopening after a second close. The new workflow adds a label and comment to indicate that auto-reopen is disabled, but does not lock the PR, allowing continued discussion and manual reopening by maintainers. * Refactor PR lock workflows and remove admin override Deleted the admin-override workflow and streamlined the logic and messaging in mistake-pr, reopen-once, and disable-auto-reopen-after-second-close workflows. Improved clarity, reduced redundancy, and updated job/step names for consistency. The admin override feature is no longer available; only maintainers can manually reopen PRs after auto-reopen is disabled.
BaronClaps
reviewed
Dec 29, 2025
Member
BaronClaps
left a comment
BaronClaps
left a comment
There was a problem hiding this comment.
Remove the draw only change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before issuing a pull request, please see the contributing page.