On offer: updated tuning tests that I believe are easier to use #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification contains multiple changes to the tuning opmodes.
The following opmodes have been modified: TranslationalTuner, HeadingTuner, DriveTuner, Line, CentripetalTuner
The all the opmodes, except CentripetalTuner, have been modified so that dpad left/right initiates appropriate motion for the opmode in question. dpad up/down modifies the distance the test travels through. The path constraints have been modified so path following does not end in order to be able to observe end of travel behavior better.
The CentripetalTuner has had the path constraints modified so path following does not end, and the timeout increased so there is a delay between the forward and backward paths.
These changes make it much easier to tune the robot, because you can see how the robot responds to small changes as well as large changes, and because you can see the end behavior more clearly since a return path is not immediately taken.