Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration Testing] PEcAn Docker Stack Run : Single Site, Single Model #3345

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from

Conversation

meetagrawal09
Copy link
Collaborator

Description

PR aims at adding a workflow for running a complete PEcAn workflow using PEcAn's docker stack.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
tests/test.xml Outdated Show resolved Hide resolved
Meet Agrawal added 2 commits August 1, 2024 22:01
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
.github/workflows/model-run.yml Outdated Show resolved Hide resolved
@meetagrawal09 meetagrawal09 marked this pull request as ready for review September 5, 2024 15:49
@@ -62,6 +62,10 @@ jobs:
sleep 50
docker ps

- name: Add models
run: |
docker compose exec --workdir /pecan/scripts executor sh add.models.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest logs are showing that the executor image doesn't have psql installed.

There are probably better ways, but I think this should work:

docker compose cp scripts/add.util.sh postgres:/tmp/add.util.sh
docker compose cp scripts/add.models.sh postgres:/tmp/add.models.sh
docker compose exec postgres /tmp/add.models.sh

Copy link
Member

@infotroph infotroph Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to suspect I'm sending you on a goose chase here. Hey @robkooper is this the right approach or should we instead be, like, starting the monitor service and waiting for it to register sipnet for us? If so what would that look like here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants