Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sites_cultivars.rb #569

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

added sites_cultivars.rb #569

wants to merge 9 commits into from

Conversation

dlebauer
Copy link
Member

I would like to have sites_cultivars associations be avaialable via api when associations_mode =full_info. I am taking a first pass at enabling this

Copy link
Contributor

@gsrohde gsrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some minimal changes that I checked in, this will at least allow getting sites-cultivars information in XML, JSON, or CSV format. But note that this uses the old API.

The "new" action does not do anything other than display a dummy SitesCultivar instance (and then only if you use the second displayed request form "GET /cultivars/new.xml" since no default format is defined). The create action doesn't work.

Most likely, you modeled this controller after the CitationsSitesController, which itself doesn't do what it pretends to.

If you let me know what functionality you actually want here, perhaps I can modify this to be useful in the ways that you want it to be.

@betydb

This comment has been minimized.

@gsrohde gsrohde removed their assignment Jun 6, 2018
@dlebauer
Copy link
Member Author

If I recall, the minimum functionality that we needed here was to be able to access the sites_cultivars relationships. Currently that is difficult to do. This would be nice to have if it is ready to deploy but at this point is low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants