-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sites_cultivars.rb #569
base: master
Are you sure you want to change the base?
Conversation
Corrects the method used to set the default request format. Adds a route for the new controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With some minimal changes that I checked in, this will at least allow getting sites-cultivars information in XML, JSON, or CSV format. But note that this uses the old API.
The "new" action does not do anything other than display a dummy SitesCultivar instance (and then only if you use the second displayed request form "GET /cultivars/new.xml" since no default format is defined). The create action doesn't work.
Most likely, you modeled this controller after the CitationsSitesController, which itself doesn't do what it pretends to.
If you let me know what functionality you actually want here, perhaps I can modify this to be useful in the ways that you want it to be.
This comment has been minimized.
This comment has been minimized.
If I recall, the minimum functionality that we needed here was to be able to access the sites_cultivars relationships. Currently that is difficult to do. This would be nice to have if it is ready to deploy but at this point is low priority. |
I would like to have sites_cultivars associations be avaialable via api when associations_mode =full_info. I am taking a first pass at enabling this